[COW-SDK] - replace SupportedChainId and change xDai > Gnosis Chain #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
alfetopito
approved these changes
May 25, 2022
nenadV91
reviewed
May 26, 2022
| } | ||
|
|
||
| const SAFE_BASE_URL = 'https://gnosis-safe.io' | ||
| const CHAIN_SHORT_NAME: Partial<Record<number, string>> = { | ||
| [ChainId.MAINNET]: 'eth', // https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-1.json | ||
| [ChainId.RINKEBY]: 'rin', // https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-4.json | ||
| [ChainId.XDAI]: 'xdai', // https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-100.json | ||
| [ChainId.GNOSIS_CHAIN]: 'xdai', // https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-100.json |
There was a problem hiding this comment.
Isn't the short name actually gno, based on this https://github.com/ethereum-lists/chains/blob/71bbadb6878db890f2763c8a84b5ed0b94d0e353/_data/chains/eip155-100.json#L21 ?
There was a problem hiding this comment.
It is, but this is only internal.
While I do agree with you and this is mildly annoying, I'm fine to have the long version
nenadV91
reviewed
May 26, 2022
| } | ||
| } | ||
|
|
||
| // Production, staging, ens, ... | ||
| return { | ||
| [ChainId.MAINNET]: process.env.REACT_APP_API_URL_PROD_MAINNET || 'https://api.cow.fi/mainnet/api', | ||
| [ChainId.RINKEBY]: process.env.REACT_APP_API_URL_PROD_RINKEBY || 'https://api.cow.fi/rinkeby/api', | ||
| [ChainId.XDAI]: process.env.REACT_APP_API_URL_PROD_XDAI || 'https://api.cow.fi/xdai/api', | ||
| [ChainId.GNOSIS_CHAIN]: process.env.REACT_APP_API_URL_PROD_XDAI || 'https://api.cow.fi/xdai/api', |
There was a problem hiding this comment.
Should we maybe update the env variable names for consistency or is it fine to leave it as this?
There was a problem hiding this comment.
Agreed, will create an issue to address it post merge
nenadV91
approved these changes
May 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of the cow-sdk integration
xdaitognosis_chain